Size is always one in curl functions#22733
Merged
Merged
Conversation
Assert and take advantage of that size is always 1. This is also documented in the curl docs. So there is no need to multiply with size, so this can be removed. I started this to see whether size * nmemb can overflow. This makes it clear that it cannot.
Contributor
Author
|
@nikic could you review this? |
Girgias
approved these changes
Jul 17, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
Note that Nikita is no longer involved with PHP.
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assert and take advantage of that size is always 1. This is also documented in the curl docs. So there is no need to multiply with size, so this can be removed.
I started this to see whether size * nmemb can overflow. This makes it clear that it cannot.